(#482) targetsdk 29#490
Merged
Merged
Conversation
Author
|
Should merge merged either together with #514 or after that one, because in this PR we don't start the WatchNotification service as foreground service which will blow up the app right after the start if we have at least one pinned thread. |
Owner
|
As I noted in my review of #449, there would be an issue for transferring a downloaded APK copy from the cache to the downloads directory if I were to merge this. |
Author
|
So I have just checked (just in case) and the updater works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
Didn't really have any problems with it so I assume it's safe to use v29.