I'm too lazy and uncomfortable to do a proper PR on a WiP.
i've tried to my best abilities and with peeking into overchan and dashchan for guidance to bring 420chan support to Kuroba (or rather my Clover Fork tbh). Checked out, it is buildable with Kuroba without errors.
Here are the added/changed files for inspection: http://ge.tt/8qluDn03 (based on commit hash 84a5fd1)
[added] core/site/common/taimaba
[added] core/site/sites/Chan420.java
[modified] core/site/SiteRegistry.java

I've basically copied over vichan and modified it slightly. My first approach was to copy the chan4 folder and modify it. This is all i can do, as i don't properly understand Java so this is a hackfest at best.

What's working: Sitesetup, thread/thumbnail/image viewing, saving threads and reading comments.
What's not working: There are quite a bit formatting issues. either the comments don't run through the CommentParser or i'd have to override some function(s). no yellowtext (greentext), no bold/italic etc. No Posting/deleting a comment, quotepatterns (reply to #). I did do some modifications in these regards in TaimabaApi.java, but i think the proper way to handle these things should be the CommentParser - please correct me if i'm wrong.

I know this is a "good first issue" but it is outside of my capabilities. I've been trying for about 1-2 weeks now and i need help going further. I'm not even sure if my approach is "correct" or it is simply dirty/hacky and unmergable.

Happily awaiting some feedback.

420chan support #413

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions