Skip to content

Added editor activity#76

Merged
johan-bjareholt merged 5 commits intomasterfrom
dev/editor-activity
Jun 17, 2018
Merged

Added editor activity#76
johan-bjareholt merged 5 commits intomasterfrom
dev/editor-activity

Conversation

@johan-bjareholt
Copy link
Copy Markdown
Member

@johan-bjareholt johan-bjareholt commented Jun 16, 2018

Todo:

  • Some minor styling fixes
  • Test with multiple editor buckets
  • Refactoring

@ghost ghost assigned johan-bjareholt Jun 16, 2018
@ghost ghost added the review label Jun 16, 2018
@johan-bjareholt
Copy link
Copy Markdown
Member Author

johan-bjareholt commented Jun 16, 2018

Have now also tested with aw-watcher-vscode with some modifications, works well!

Otto-AA/aw-watcher-vscode#2

@Otto-AA
Copy link
Copy Markdown

Otto-AA commented Jun 17, 2018

Can't test because the app can't connect to the aw-server.
It fails at this part:

awclient.info().then(
   (response) => {
     if (response.status > 304) {
       console.error("Status code from return call was >304");
     } else {
       this.connected = true;
       this.info = response.data;
     }

because it somehow makes the request with the method OPTIONS instead of GET. (Tested resending the request with GET and got the correct response). From the aw-client-js it seems to me that it should make a get request.
A screenshot of the request (180kb is sent request, 0kb is response)
image

Do you have any ideas how to fix this?

@johan-bjareholt
Copy link
Copy Markdown
Member Author

johan-bjareholt commented Jun 17, 2018

@Otto-AA It's clear in the aw-client-js code that info does a GET request so I'm not sure what is happening there. It should not even be allowed to send a OPTIONS request with a body so it doesn't make sense to me.

Copy link
Copy Markdown
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johan-bjareholt johan-bjareholt merged commit 9aacac7 into master Jun 17, 2018
@ghost ghost removed the review label Jun 17, 2018
@johan-bjareholt johan-bjareholt deleted the dev/editor-activity branch October 24, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants