Skip to content

feat: more applications in the default category rules#261

Merged
ErikBjare merged 8 commits intoActivityWatch:masterfrom
Mte90:patch-2
May 26, 2021
Merged

feat: more applications in the default category rules#261
ErikBjare merged 8 commits intoActivityWatch:masterfrom
Mte90:patch-2

Conversation

@Mte90
Copy link
Copy Markdown
Contributor

@Mte90 Mte90 commented Feb 24, 2021

Just few new apps

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #261 (53cab56) into master (86b8eab) will increase coverage by 2.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   13.89%   15.91%   +2.01%     
==========================================
  Files          22       22              
  Lines        1036     1062      +26     
  Branches      101      110       +9     
==========================================
+ Hits          144      169      +25     
- Misses        847      848       +1     
  Partials       45       45
Impacted Files Coverage Δ
src/util/classes.ts 81.69% <ø> (+1.38%) ⬆️
src/util/color.ts 33.33% <0.00%> (-3.41%) ⬇️
src/queries.ts 15.06% <0.00%> (-0.88%) ⬇️
src/main.js 0.00% <0.00%> (ø)
src/util/awclient.js 0.00% <0.00%> (ø)
src/store/modules/activity.ts 6.10% <0.00%> (ø)
src/store/modules/views.js
src/store/modules/views.ts 43.90% <0.00%> (ø)
src/store/modules/categories.js 68.25% <0.00%> (+5.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b8eab...53cab56. Read the comment docs.

iloveitaly
iloveitaly reviewed May 4, 2021
View reviewed changes
@iloveitaly
Copy link
Copy Markdown
Contributor

iloveitaly commented May 4, 2021

I hope we can get broader default categorizations like this merged in! I think this is super helpful.

@ErikBjare ErikBjare mentioned this pull request May 4, 2021
Open
@iloveitaly iloveitaly mentioned this pull request May 5, 2021
Closed
@johan-bjareholt
Copy link
Copy Markdown
Member

johan-bjareholt commented May 24, 2021

I think this PR is pretty nicely structured and broad, just needs to fix a few linting errors.
After that I'm OK with merging this. @ErikBjare What do you think?

ErikBjare
ErikBjare reviewed May 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things, will apply them myself and go ahead and merge.

@ErikBjare
Copy link
Copy Markdown
Member

ErikBjare commented May 26, 2021

Only screenshot thingy failing due to permissions. Merging.

Thanks for your contribution @Mte90! Sorry for not getting around to this sooner.

@ErikBjare ErikBjare changed the title More applications based on my must used app feat: more applications in the default category rules May 26, 2021
@ErikBjare ErikBjare merged commit d9782c3 into ActivityWatch:master May 26, 2021
@Mte90 Mte90 deleted the patch-2 branch May 26, 2021 12:01
@Mte90
Copy link
Copy Markdown
Contributor Author

Mte90 commented May 26, 2021

No problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikBjare ErikBjare ErikBjare left review comments

+1 more reviewer

@iloveitaly iloveitaly iloveitaly left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mte90 @iloveitaly @johan-bjareholt @ErikBjare