perf: use win32 API instead of WMI to query process information #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is awesome. Great work, thanks @chengyuhui! ❤️ |
2 tasks
2 tasks
2 tasks
Member
|
@chengyuhui This created a regression for applications run as administrator, which you can read about in ActivityWatch/activitywatch#873 Are you interested in working on a fix? Namely to use the newer method, but in the cases that it fails, fallback to using wmi. I've asked @BelKed about it here, thought I'd ask you too :) |
Contributor
Author
|
I no longer use AW on my Windows system since I have migrated my main desktop to Arch. You guys can go ahead and fix this :) |
Member
|
Congratulations on Arch-maxing! 🤩 I guess I'll make a PR myself and find someone to test it later :) |
This was referenced Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Windows implementation to use native Windows APIs instead of WMI, which does not consume much CPU (barely noticeable when polling with an interval of 1 second).
This should also remove the dependency on
wmipackage, but I am having difficulty using Poetry, so that change is not made.