Replace rocket to url for URI parsing#484
Merged
ErikBjare merged 2 commits intoActivityWatch:masterfrom Jun 11, 2024
Merged
Conversation
Url crate is most popular and basic for the task. Rocket version in aw-transform is also out of sync with aw-server, which may cause a conflict elsewhere.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1148540 in 1 minute and 8 seconds
More details
- Looked at
474lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw-transform/src/split_url.rs:44
- Draft comment:
The domain extraction logic removes the "www." prefix, which is generally a good approach for normalizing domain names. However, this might not be desired in all cases, and it could be beneficial to make this behavior configurable or clearly document it. - Reason this comment was not posted:
Confidence changes required:33%
The PR description mentions that theurlcrate is being used because it is more popular and basic for the task, and there is a version conflict withrocketinaw-transformandaw-server. The changes in theCargo.tomlandCargo.lockreflect this update by removingrocketand addingurlalong with its dependencies. The code changes insplit_url.rsreplace therocketURI parsing withurlcrate parsing. The logic for extracting components from the URL (protocol, domain, path, params) is correctly updated to use the methods provided by theurlcrate.
Workflow ID: wflow_p1eYTXo2pBBycALz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Reqwest specifies a particular version which may be a problem.
Member
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Url crate is most popular and basic for the task.
Rocket version in aw-transform is also out of sync with aw-server, which may cause a conflict elsewhere.
Summary:
Replaced
rocketcrate withurlfor URI parsing inaw-transformto resolve version conflicts and use a more popular crate.Key points:
rocketcrate withurlcrate inaw-transform.Cargo.tomlandsplit_url.rsto useurlfor URI parsing.aw-transformandaw-server.Generated with ❤️ by ellipsis.dev