Skip to content

Major categorization work (timeplot, sunburst, Python-func to query through inspection, etc.)#12

Merged
ErikBjare merged 23 commits intomasterfrom
dev/fancyquery
Dec 28, 2018
Merged

Major categorization work (timeplot, sunburst, Python-func to query through inspection, etc.)#12
ErikBjare merged 23 commits intomasterfrom
dev/fancyquery

Conversation

@ErikBjare
Copy link
Copy Markdown
Member

@ErikBjare ErikBjare commented Nov 1, 2018

@ghost ghost assigned ErikBjare Nov 1, 2018
@ghost ghost added the review label Nov 1, 2018
@ErikBjare ErikBjare changed the title Fancy query thingie Major categorization work (query-construction from Python-inspection, timeplot, sunburst, etc.) Dec 14, 2018
@ErikBjare ErikBjare changed the title Major categorization work (query-construction from Python-inspection, timeplot, sunburst, etc.) Major categorization work (timeplot, sunburst, Python-func to query through inspection etc.) Dec 14, 2018
@ErikBjare ErikBjare changed the title Major categorization work (timeplot, sunburst, Python-func to query through inspection etc.) Major categorization work (timeplot, sunburst, Python-func to query through inspection, etc.) Dec 14, 2018
@ErikBjare
Copy link
Copy Markdown
Member Author

ErikBjare commented Dec 28, 2018

Travis is finally passing, merging.

@ErikBjare ErikBjare merged commit 5593917 into master Dec 28, 2018
@ghost ghost removed the review label Dec 28, 2018
@ErikBjare ErikBjare deleted the dev/fancyquery branch January 7, 2019 08:32
@rTreutlein
Copy link
Copy Markdown

rTreutlein commented Apr 5, 2019

So I started using this and just wanted to add some comments.

  1. There exists a categories.example.csv and a parent_categories.csv.example, first of all, that's inconsistently named but primarily the code seems to expect a combination of booth called "category_regexes.csv"
  2. the get_events function has an include_smartertime parameter set to 'auto' which caused a crash seems like this should be filepath with how it's used really not sure. Anyway setting it to False fixed the crash.
  3. There is a hardcoded toggl file which of course doens't exist on my system. So i had to remove that.
  4. Also the code seemed to expect the existence of a bucket for both Chrome and FireFox. As I rarely use Firefox it crashed initially till I added that bucket.

Other than that it seems to be working quite nicely. If you want I can make a pull request with the above issues fixed.

@ErikBjare
Copy link
Copy Markdown
Member Author

@rTreutlein Great that you got it working! It wasn't really intended for use by anyone else than me yet (which is why the code is a bit of a mess).

Please create a PR with your fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants