Able to resolve propery HTTP client when http option is str#1
Closed
encyphered wants to merge 1 commit intoAccelByte:mainfrom
Closed
Conversation
Contributor
|
Hi, our engineer have taken a look on this PR and it looks good. It is accepted. However, currently our repository setup does not allow to merge this PR directly on GitHub. So, our engineer have taken this PR and merge it into our internal repo before releasing it on GitHub. It is included in this release https://github.com/AccelByte/accelbyte-python-sdk/releases/tag/v0.2.1. Tell us if you have additional input on this. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm Geunwoo from the Krafton GPP team.
https://github.com/AccelByte/accelbyte-python-sdk/blob/09c1e98/accelbyte_py_sdk/core/_core.py#L83-L90
In initialization function,
accelbyte_py_sdk.core.initialize, we can define HTTP client to use by passing options with 'http' dictionary key. The value could be str or class but when the type of the value is str, it can resolve implementation from_HTTP_CLIENT_IMPLbut object initialization is lack. It assigns just string value to the global _HTTP_CLIENT variable and it makes an error. Fixing this.Reproducing:
will occur