Skip to content

Adsk Contrib - Fix GPU build on RB-2.0#1412

Merged
hodoulp merged 2 commits intoRB-2.0from
adsk_contrib/fix_gpu_issue
Jun 28, 2021
Merged

Adsk Contrib - Fix GPU build on RB-2.0#1412
hodoulp merged 2 commits intoRB-2.0from
adsk_contrib/fix_gpu_issue

Conversation

@hodoulp
Copy link
Copy Markdown
Member

@hodoulp hodoulp commented Jun 14, 2021

Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com

The pull request tries to improve / fix the RB-2.0 build for GPU which fails quite often...
The GPI CI build should not trigger when starting from a forked branch.

The other changes are only here to impose a compilation.

Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
@hodoulp
Copy link
Copy Markdown
Member Author

hodoulp commented Jun 14, 2021

Based on the current checks, the GPU is not started. That's a first good point. Now, let see if it succeeds.

@hodoulp hodoulp requested a review from michdolan June 14, 2021 22:58
@hodoulp
Copy link
Copy Markdown
Member Author

hodoulp commented Jun 15, 2021

To avoid the Windows and macOS emulation mode, the GPU CI build needs a physical machine adding some costs. So, the original intent was to only run the GPU CI build on the repo itself (i.e. not running on forks) to limit fees. The ASWF offers the GPU build capability but OpenColorIO should then try to wisely use it. Starting few weeks ago, the GPU CI build was also executed on forks!

Thanks to @Simran-B, we finally discover that the execution condition was, in fact, wrong.

As github.repository is the repo the workflow is running in, this will always be true for the official repo. Usually one would use github.event.pull_request.head.repo.full_name != github.repository as condition to prevent jobs from running if they originate from a fork, [...]

@hodoulp hodoulp marked this pull request as ready for review June 15, 2021 13:00
@hodoulp hodoulp merged commit 54e5512 into RB-2.0 Jun 28, 2021
@hodoulp hodoulp deleted the adsk_contrib/fix_gpu_issue branch June 28, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants