fix: parse CSI Z (backtab) as Shift+Tab#297
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CSI Z (backtab / reverse tab) not being recognized as Shift+Tab. Previously, the Z final byte was not in the
functional key set, so terminals that emit ESC [ Z for Shift+Tab produced no usable input event. Now it correctly
maps to Tab with the Shift modifier.
Problem
Many terminals (xterm, GNOME Terminal, Windows Terminal in legacy mode) emit CSI Z when the user presses
Shift+Tab. Termina's CSI decoder did not recognize Z as a functional final byte, so backtab input was silently
dropped. This broke Shift+Tab navigation in pages that register it (e.g. clipboard gallery's focus cycling).
Changes
CsiFunctionalDecoder.cs — Add Z to IsFunctionalFinal, map it to ConsoleKey.Tab / TerminaKey.Tab, and attach the
Shift modifier via new FinalToModifiers / FinalToKeyModifiers helpers.
CsiFunctionalDecoderTests.cs — Three new tests: bare Z final returns Tab+Shift, same under Kitty-visible mode, and
IsFunctionalFinal('Z') returns true.
EscapeSequenceParserTests.cs — Integration test: full ESC [ Z sequence emits KeyPressed with ConsoleKey.Tab +
Shift.
Test plan