input release dispatcher#8785
Closed
anapnoe wants to merge 3 commits into
Closed
Conversation
Owner
|
Well, I did upgrade to the last gradio, so this would probably need to be reworked a bit to support it. Gradio did add a Since this is a fix to one function, I'd like it to sit in a separate .js file named appropriately. You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a universal fix for all input number fields and sliders of the UI including scripts and extensions to dispatch the change event on release of current action thus gaining better user experience, responsiveness and performance. It is optimized to work with total of 5 extra event listeners for all sliders and numeric input fields, achieving low overhead and minimum memory impact noted that gradio's current solution version 3.22 uses 3 extra event listeners for each slider without addressing the numeric input fields at all
you don't need to modify any of the source py files for this to work you can enable it or disable it globally through options
gradio-app/gradio#3204
slider_proto.mp4
Environment this was tested in