Return HTTP 400 instead of 404 on invalid sampler error#16140
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Jul 6, 2024
Merged
Return HTTP 400 instead of 404 on invalid sampler error#16140AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
Conversation
Mosig33
approved these changes
Jul 3, 2024
AUTOMATIC1111
approved these changes
Jul 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to a confusion I experienced while using it for my own project, I think it would be more accurate to give a 400 error instead of 404 on API design. Because this error is mostly related to the validation of the payload of the request. The endpoint which request made is actually exists. Please take a look at HTTP 404 and HTTP 400 error descriptions.
Screenshots/videos:
No screenshots required.
Checklist: