Skip to content

fix infotext Lora hashes fro hires fix different lora#16062

Merged
AUTOMATIC1111 merged 1 commit intodevfrom
fix-infotext-Lora-hashes-fro-hires-fix-different-lora
Jul 6, 2024
Merged

fix infotext Lora hashes fro hires fix different lora#16062
AUTOMATIC1111 merged 1 commit intodevfrom
fix-infotext-Lora-hashes-fro-hires-fix-different-lora

Conversation

@w-e-w
Copy link
Copy Markdown
Collaborator

@w-e-w w-e-w commented Jun 21, 2024

Description

there exist a minor flaw with infotext Lora hashes

currently the Lora hashes written to the infotext will be the Lora hashes of the "last last activated lores"
normally this works perfectly fine
the issue occurs when the using hires fix
as hires fix allows diffrent prompt which means the user can change the lora
if the uses removs some loras that are in the first pass then the Lora hashes infotext will not have the loras of the first pass obviously


this PR makes changes so it saves the lora hashes in saved in a dict under p.lora_hashes
when on first pass the dict will be set to empty {}
but is_hr_pass it will use the use the existing p.lora_hashes and add any new hashes to the dict

tested with the hires fix button and all seems to work fine

also compacted the code


TI hashes also have similar issues but and more
worse possibly due to where the code is it doesn't even write to infotext consistently
currently I not sure how to fix that, maybe someone who have an idea

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner June 21, 2024 06:31
@AUTOMATIC1111 AUTOMATIC1111 merged commit 3bd4a08 into dev Jul 6, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-infotext-Lora-hashes-fro-hires-fix-different-lora branch July 6, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants