fix infotext Lora hashes fro hires fix different lora#16062
Merged
AUTOMATIC1111 merged 1 commit intodevfrom Jul 6, 2024
Merged
fix infotext Lora hashes fro hires fix different lora#16062AUTOMATIC1111 merged 1 commit intodevfrom
AUTOMATIC1111 merged 1 commit intodevfrom
Conversation
AUTOMATIC1111
approved these changes
Jul 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
there exist a minor flaw with infotext
Lora hashescurrently the
Lora hasheswritten to the infotext will be theLora hashesof the "last last activated lores"normally this works perfectly fine
the issue occurs when the using hires fix
as hires fix allows diffrent prompt which means the user can change the lora
if the uses removs some loras that are in the first pass then the
Lora hashesinfotext will not have the loras of the first pass obviouslythis PR makes changes so it saves the lora hashes in saved in a dict under
p.lora_hasheswhen on first pass the dict will be set to empty
{}but
is_hr_passit will use the use the existingp.lora_hashesand add any new hashes to the dicttested with the hires fix button and all seems to work fine
also compacted the code
TI hashesalso have similar issues but and moreworse possibly due to where the code is it doesn't even write to infotext consistently
currently I not sure how to fix that, maybe someone who have an idea
Checklist: