fix: correct PYTHONPATH for extentions installation proccess#15704
Closed
shsotoudegan wants to merge 1 commit intoAUTOMATIC1111:devfrom
Closed
fix: correct PYTHONPATH for extentions installation proccess#15704shsotoudegan wants to merge 1 commit intoAUTOMATIC1111:devfrom
shsotoudegan wants to merge 1 commit intoAUTOMATIC1111:devfrom
Conversation
1 task
4 tasks
Collaborator
why would you need the |
Author
yes. that's can remove. |
Collaborator
well then this PR is redundant there's absolutely no need of adding a try block for doing the exact same thing twice closing this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
run_extension_installerfunction. The try block attempts to add the correct stable-diffusion-webui root path to thePYTHONPATHenvironment variable. It does this by converting the relative path (frommodules/launch_utils.pyto the project root) to an absolute path. The Path from the pathlib library is imported for this purpose.python -m ruff checkChecklist: