Skip to content

dont send server address in a-href#15631

Closed
light-and-ray wants to merge 1 commit intoAUTOMATIC1111:devfrom
light-and-ray:dont_send_server_address_for_a_href
Closed

dont send server address in a-href#15631
light-and-ray wants to merge 1 commit intoAUTOMATIC1111:devfrom
light-and-ray:dont_send_server_address_for_a_href

Conversation

@light-and-ray
Copy link
Copy Markdown
Contributor

@light-and-ray light-and-ray commented Apr 26, 2024

Description

Gradio sets these tags automatically when generates hyperlinks from markdown rel="noopener noreferrer" I've added them into webui's html

You can see users' non-local server addresses (e.g. --share or their hosting) in github's repo statistics for example, when they go to the repo via Extensions tab. Other sites can see them too. This PR fixes this

Checklist:

@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Apr 27, 2024

I think it might be possible to just set Referrer-Policy header no-referrer
to automatically apply to the entire web page
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

@w-e-w w-e-w mentioned this pull request Apr 27, 2024
4 tasks
@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Apr 27, 2024

@light-and-ray
Copy link
Copy Markdown
Contributor Author

I thinks it's good to merge both

@w-e-w
Copy link
Copy Markdown
Collaborator

w-e-w commented Apr 29, 2024

I thinks it's good to merge both

in my opinion if the global one works then just the global one is better
less clutter the the code

@AUTOMATIC1111
Copy link
Copy Markdown
Owner

I merged the other one and if it achieves the result, I don't want to add more changes. If this change is still wanted, reopen the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants