Skip to content

open_folder as util#15442

Merged
AUTOMATIC1111 merged 3 commits intodevfrom
open_folder-as-util
Apr 6, 2024
Merged

open_folder as util#15442
AUTOMATIC1111 merged 3 commits intodevfrom
open_folder-as-util

Conversation

@w-e-w
Copy link
Copy Markdown
Collaborator

@w-e-w w-e-w commented Apr 5, 2024

Description

extract the open_folder in ui_common.create_output_panel as a util so it can be resues by extensions

I've seen several instances of extensions needing the same open_folder function but couldn't reuse the one in webui because it's in create_output_panel, they endend up haveing to essentially copy and paste and create a new function

I import the modules at function level and not module level because feel especially gradio import would cause issues

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner April 5, 2024 07:07
@w-e-w w-e-w changed the base branch from master to dev April 5, 2024 07:08
@w-e-w w-e-w force-pushed the open_folder-as-util branch from 73c8b97 to 92e6aa3 Compare April 5, 2024 07:08
@AUTOMATIC1111 AUTOMATIC1111 merged commit 447198f into dev Apr 6, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the open_folder-as-util branch April 6, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants