Skip to content

Make imageviewer event listeners browser consistent#15261

Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
catboxanon:fix/imageviewer-click
Mar 16, 2024
Merged

Make imageviewer event listeners browser consistent#15261
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
catboxanon:fix/imageviewer-click

Conversation

@catboxanon
Copy link
Copy Markdown
Collaborator

@catboxanon catboxanon commented Mar 15, 2024

Description

Fixes two issues:

  • The issue mentioned in the comment seems no longer applicable in the current Gradio version with Firefox, at least as far as I could tell in testing. This is removed and thus makes the picture draggable in Firefox.
  • When the event listener was set to click in Chrome, and the MMB button was used, but autoscroll was enabled, it prevented the image from being opened in a new tab. This uses mousedown in all browsers so not to interfere with autoscroll.

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0cc3647 into AUTOMATIC1111:dev Mar 16, 2024
@catboxanon catboxanon deleted the fix/imageviewer-click branch March 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants