Skip to content

Added core.filemode=false so doesn't track changes in file permission…#14930

Merged
AUTOMATIC1111 merged 1 commit intodevfrom
unknown repository
Feb 17, 2024
Merged

Added core.filemode=false so doesn't track changes in file permission…#14930
AUTOMATIC1111 merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 15, 2024

…s in more restrictive environments

Description

  • In more restrictive environments such as a mounted GDrive the drive can change permissions on some cloned files.
  • At the moment, once a repo is cloned and if file permissions get updated it registers it as a change in git and then future updates can't be applied as it requests for your changes to be stashed or committed first
  • This can be quite confusing for people who aren't familiar with git and haven't changed anything themselves

Checklist:

^^ I struggled with the tests as my dev environment doesn't have an GPU, I've used Forge with this change in on CoLab and it works well - it would be greatly appreciated if someone could run the tests on their environment - I expect them to pass as this is a very small change that won't have an impact in most environments

@ghost ghost requested a review from AUTOMATIC1111 as a code owner February 15, 2024 12:47
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 16, 2024

Is there anything else you need from me for this?

@AUTOMATIC1111 AUTOMATIC1111 merged commit a56125b into AUTOMATIC1111:dev Feb 17, 2024
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant