Skip to content

fix extra-network-control--enabled color#14900

Merged
AUTOMATIC1111 merged 1 commit intodevfrom
fix-css-color-extra-network-control--enabled
Feb 17, 2024
Merged

fix extra-network-control--enabled color#14900
AUTOMATIC1111 merged 1 commit intodevfrom
fix-css-color-extra-network-control--enabled

Conversation

@w-e-w
Copy link
Copy Markdown
Collaborator

@w-e-w w-e-w commented Feb 11, 2024

Description

  • fix extra-network-control--enabled color

the color for extra-network-control--enabled css is broken,
there's duplicate rules for dark mode but none for light mode
I also change it to use transparency so that it looks better

Note
Personally I'm not too keen on highlighting icon whn enabled, I think it's unnecessary
hover highlighting might be a thing
this PR is more about fix the broken CSS so I did not remove it

Screenshots/videos:

Light Dark
Disable 2024-02-12 04_04_27_807 2024-02-12 04_04_30_889 2024-02-12 04_04_33_387 2024-02-12 04_04_07_921 chrome 2024-02-12 04_04_20_539 2024-02-12 04_04_25_093
Enable 2024-02-12 04_04_28_963 2024-02-12 04_04_32_116 2024-02-12 04_04_34_536 2024-02-12 04_04_16_175 2024-02-12 04_04_22_395 2024-02-12 04_04_26_190

other minor changes

Checklist:

also add forgotten semicolon
@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner February 11, 2024 20:03
@AUTOMATIC1111 AUTOMATIC1111 merged commit f293dbb into dev Feb 17, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-css-color-extra-network-control--enabled branch February 17, 2024 06:00
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants