Skip to content

if extensions page not loaded, prevent apply#14873

Merged
AUTOMATIC1111 merged 1 commit intodevfrom
check_extensions_list_on_apply_js_method
Feb 11, 2024
Merged

if extensions page not loaded, prevent apply#14873
AUTOMATIC1111 merged 1 commit intodevfrom
check_extensions_list_on_apply_js_method

Conversation

@w-e-w
Copy link
Copy Markdown
Collaborator

@w-e-w w-e-w commented Feb 9, 2024 •
edited
Loading

Description

since they are built-in extensions we can make the assumption that they will be at least one or more extensions

if length is 0 then throws an error

also if for whatever reason there is no extensions then this doesn't matter anymore

to manually test this you can put a breakpoint in

stable-diffusion-webui/modules/ui_extensions.py

Line 136 in d69a794

def extension_table():

Screenshots/videos:

image

Checklist:

@w-e-w @light-and-ray
if extensions page not loaded, prevent apply
6b8458e 
since they are built-in extensions we can make the assumption that they will be at least one or more extensions

Co-Authored-By: Andray <33491867+light-and-ray@users.noreply.github.com>
@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner February 9, 2024 14:23
@AUTOMATIC1111 AUTOMATIC1111 merged commit 2f1e2c4 into dev Feb 11, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the check_extensions_list_on_apply_js_method branch February 11, 2024 05:29
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
Closed
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@w-e-w @AUTOMATIC1111