[Bug] Fix extras big batch crashes#14699
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Jan 20, 2024
Merged
Conversation
4 tasks
AUTOMATIC1111
approved these changes
Jan 20, 2024
Closed
Closed
6 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found postprocessing in extras tab stably crashes for big batches. It happens because
shared.state.assign_current_image(image_data)And later:
image_data.close()Inside
postprocessing.pyAnd also I think it's better to show processed image in preview instead of input image. I decided to fix this crash with using pp.image instead of image_data for preview
Checklist: