Merged
Conversation
Owner
|
Wait, really? I was sure it worked when I tested it. Not the subseed part, but the seed did match. I added |
Owner
|
Oh, it must be because of the |
AUTOMATIC1111
approved these changes
Jan 9, 2024
Collaborator
Author
|
ahh it makes sense now txt2img_create_processing |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
follow up of 15ec54d Have upscale button use the same seed as hires fix.
that doesn't actually work
seedis set by theseed scriptin thesetup()too late to modify it using
modules.scripts.scripts_txt2img.set_named_arg, I have to directly modifyp.seedyou forget about
sub seedsI've been having trouble getting all 3 out put
normal hires fix (the old input accordion)
manual hires fix (txt2img -> upscale -> image)
and 2 stage hires fix (this nuw button)
to be the match (pixel perfect)
Checklist: