Skip to content

Spandrel: "prefer half" instead of "force half"#14500

Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
akx:spandrel-prefer-half
Jan 2, 2024
Merged

Spandrel: "prefer half" instead of "force half"#14500
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
akx:spandrel-prefer-half

Conversation

@akx
Copy link
Copy Markdown
Collaborator

@akx akx commented Jan 2, 2024

Description

As discussed with the Spandrel folks, it's good to heed Spandrel's "supports half precision" flag to avoid e.g. black blotches and what-not.

This is why spandrel has the supports_half tag. Transformer models typically don't work well with fp16

  • which issues it fixes, if any
    • None yet, since the current experimental HAT code doesn't set half=True, but if it did, HAT would have a bad time

Screenshots/videos:

None.

Checklist:

As discussed with the Spandrel folks, it's good to heed Spandrel's
"supports half precision" flag to avoid e.g. black blotches and what-not.
@akx akx force-pushed the spandrel-prefer-half branch from bfccd75 to 2cacbc1 Compare January 2, 2024 08:44
@akx akx marked this pull request as ready for review January 2, 2024 08:50
@akx akx requested a review from AUTOMATIC1111 as a code owner January 2, 2024 08:50
@AUTOMATIC1111 AUTOMATIC1111 merged commit 7c3ab41 into AUTOMATIC1111:dev Jan 2, 2024
@akx akx deleted the spandrel-prefer-half branch January 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants