Fix lint issue from 501993eb#14495
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Jan 1, 2024
Merged
Conversation
AUTOMATIC1111
approved these changes
Jan 1, 2024
Owner
|
my bad; I keep making this mistake over and over with js; python... |
Collaborator
Author
|
Heh, well, Lua was even worse – everything is global and you can also write to global names unless you declare them Compounded by the fact that the global function to get a type from a variable is |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ESlint doesn't like polluting global namespaces like that.
Also, unless you really do need to rebind
this,foo(...args)is the more modern idiom forfoo.apply(null, args).Checklist: