Drop basicsr dependency#14467
Merged
AUTOMATIC1111 merged 4 commits intoAUTOMATIC1111:devfrom Dec 30, 2023
Merged
Conversation
Collaborator
|
it seems |
Collaborator
AUTOMATIC1111
approved these changes
Dec 30, 2023
Owner
|
There is possibility for some extension to break if it uses the library assuming webui requires it. |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Post #14425, we only used
basicsrforimg2tensorandtensor2img; this PR vendors the relevant bits (RGB tensors/images only, RGB<->BGR conversion always) into a couple of functions to get rid ofbasicsras a direct dependency altogether.I also noticed I'd screwed up with the typing for
restore_face, so that gets fixed too.Screenshots/videos:
None. I did double-check the
test-outputsfor face restoration, and they look like they did before. I also checked that the RGB/BGR conversion is necessary; they were very screwy otherwise. 😁Checklist: