use extension name for determining an extension is installed in the index#14063
Merged
AUTOMATIC1111 merged 2 commits intoAUTOMATIC1111:devfrom Dec 2, 2023
Merged
Conversation
Owner
|
Maybe combine both? An extension is installed if either the remote matches or the directory name. |
Contributor
Author
Sure. That could be better. |
AUTOMATIC1111
approved these changes
Dec 2, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale behind this change
insteadOfgit config directive, the entireinstalledtag will bork as no remote url will match that in the index.AssertionError: Extension directory already existsremotefield anyway.Checklist: