Fix for #10643 (Inpainting mask sometimes not working)#10644
Merged
AUTOMATIC1111 merged 1 commit intoMay 22, 2023
Conversation
…reaking inpainting, so that it behaves like plain img2img)
Owner
|
This doesn't happen on my machine neither in Firefox nor in Chrome. But the change looks reasonable and harmless so I would merge it. The question is, does this happen to a lot of people? If yes, apart from putting it into dev I'd also include it as a bugfix to RC. |
Contributor
Author
|
I've searched for other people having the same problem and I've only found one or two people. So it seems to be quite rare. |
AUTOMATIC1111
approved these changes
May 22, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
A fix for #10643. Short summary: In the chrome webui the HTML canvas for painting the inpainting mask has some noise (on my machine :) ). The backend treats any non 0 pixel as white. As a result the entire mask map turns white and the entire image is changed. This PR fixes that.
Additional notes and description of your changes
The fix converts the initial painted mask to a pure black and white image, with no gradients. If there should be a need for a grayscale mask, this won't work. This doesn't affect the gaussian blur that is applied later on in the process.
Environment this was tested in
Screenshots or videos of your changes
N/A