launch.py: fix git_tag() & fix commit_hash() & simplify#10321
Merged
Conversation
AUTOMATIC1111
approved these changes
May 12, 2023
|
@AUTOMATIC1111 This commit introduces a regression where the pytorch cuda check halts forever Using "--skip-torch-cuda-test" seems to work around it Also version and commit hash cannot be detected anymore : dev |
Collaborator
Author
|
Fixed by #10384. Sorry for the trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
I broke
git_tag()andcommit_hash()whenliveis forced to True, so this fixes those two functions to not userun()becausecheck_output()is a thing,On that note, this also simplifies a pair of functions that were only called once anymore.
Environment this was tested in