[feat] Add configurable conflict handling#141
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
- Coverage 82.19% 82.01% -0.19%
- Complexity 500 507 +7
============================================
Files 38 41 +3
Lines 1820 1840 +20
Branches 269 271 +2
============================================
+ Hits 1496 1509 +13
- Misses 209 212 +3
- Partials 115 119 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #139
Fix #140
This PR adds configurability for conflict handling. It's currently not exposed to the user, it's mostly a proof-of-concept for later adding a plugin system.
The
OptimisticInsertInsertHandleris an example of an extension to conflict handling that previously was not there.