Skip to content

ConformU incorrectly flags issue when windspeed is 0.0 and winddirection is not implemented #26

@arobicha

Description

@arobicha

While running a conformance test with our Observing Conditions capable Alpaca device using ConformU v4.1.0 (Build 34702.5571b36) we get the following issue:

11:59:24.331 WindSpeed                           ISSUE    When wind speed is reported as 0.0, wind direction should also be reported as 0.0, it is actually reported as NaN

Our sensor reports Wind Direction is not implemented, which results in this line producing a windDirection of BAD_VALUE (i.e. NaN)

See: ObservingConditionsTester.cs#L326

windDirection = TestDouble(PROPERTY_WINDDIRECTION, ObservingConditionsProperty.WindDirection, 0.0, 360.0, Required.Optional);

See: ObservingConditionsTester.cs#L330

// Additional test to confirm that the reported direction is 0.0 if the wind speed is reported as 0.0
if ((windSpeed == 0.0))
{
    if ((windDirection == 0.0))
        LogOk(PROPERTY_WINDSPEED, "Wind direction is reported as 0.0 when wind speed is 0.0");
    else
        LogIssue(PROPERTY_WINDSPEED, string.Format("When wind speed is reported as 0.0, wind direction should also be reported as 0.0, it is actually reported as {0}", windDirection));
}

Desired behavior is for ConformU to recognize the winddirection is not implemented, and ignore issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions