Skip to content

Fixed colorama Python package#8390

Merged
adbridge merged 1 commit intoARMmbed:masterfrom
cmonr:fix-colorama-pkg-version
Oct 12, 2018
Merged

Fixed colorama Python package#8390
adbridge merged 1 commit intoARMmbed:masterfrom
cmonr:fix-colorama-pkg-version

Conversation

@cmonr
Copy link
Copy Markdown
Contributor

@cmonr cmonr commented Oct 11, 2018 •
edited
Loading

Description

Colorama package being at the top of the requirements.txt list causes other requirements to not be fufilled. All packages require <0.4.0, aka the latest 0.3.x patch release.

Since this was the first line in requirements.txt, colorama v0.4.0 was recently released: https://github.com/tartley/colorama/releases/tag/0.4.0

Once installed, manifest-tool and mbed-greentea would (properly) fail because they need a 0.3.x. Not sure why pip isn't able to correct this, but I digress.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Fixed colorama Python package
7252618 
Colorama package being at the top of the requirements.txt list causes other requirements to not be fufilled.
All packages require <0.4.0, aka the latest 0.3.x patch release.

:
@cmonr cmonr requested review from a team October 11, 2018 20:25
@studavekar
Copy link
Copy Markdown
Contributor

studavekar commented Oct 11, 2018

These changes look good, we should also revisit other packages as well in requirement.txt like greentea which says mbed-greentea>=0.2.24 current version been 1.4.1

@cmonr cmonr mentioned this pull request Oct 11, 2018
Closed
@cmonr
Copy link
Copy Markdown
Contributor Author

cmonr commented Oct 11, 2018

These changes look good, we should also revisit other packages as well in requirement.txt like greentea which says mbed-greentea>=0.2.24 current version been 1.4.1

Good point. Issue made for tracking: #8396

@cmonr
Copy link
Copy Markdown
Contributor Author

cmonr commented Oct 12, 2018

/morph build

@mbed-ci
Copy link
Copy Markdown

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3335
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8390/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link
Copy Markdown

mbed-ci commented Oct 12, 2018

Exporter Build : SUCCESS

Build number : 2967
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8390/

@mbed-ci
Copy link
Copy Markdown

mbed-ci commented Oct 12, 2018

Test : SUCCESS

Build number : 3143
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8390/3143

@adbridge adbridge merged commit 4c3b3f0 into ARMmbed:master Oct 12, 2018
@cmonr cmonr mentioned this pull request Oct 25, 2018
Merged
@JanneKiiskila
Copy link
Copy Markdown
Contributor

JanneKiiskila commented Oct 25, 2018

Should there not be a follow-up task on the tools to be update to work with colorama 0.4.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@studavekar studavekar studavekar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cmonr @studavekar @mbed-ci @JanneKiiskila @0xc0170 @adbridge