Skip to content

mbed compile : enable flash option with dual core targets#964

Merged
rwalton-arm merged 1 commit intoARMmbed:masterfrom
jeromecoutant:PR_DUAL
Jun 8, 2020
Merged

mbed compile : enable flash option with dual core targets#964
rwalton-arm merged 1 commit intoARMmbed:masterfrom
jeromecoutant:PR_DUAL

Conversation

@jeromecoutant
Copy link
Copy Markdown
Contributor

mbed compile -m DISCO_H747I_CM4 -t ARM -f
is using mbedls result to detect the correct plugged target on host.

There is an issue with dual core chips,
because 2 different targets exist in the targets.json file for the same HW

Associated patch for mbed test command:
ARMmbed/mbed-os#12630

@MarceloSalazar
@LMESTM

@MarceloSalazar
Copy link
Copy Markdown
Contributor

@madchutney please check this and share comments.

Copy link
Copy Markdown
Collaborator

@madchutney madchutney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too dangerous, as far as I can see it removes all occurrences of the string from the target meaning that no target can have or can ever have those substrings in the name.

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

@madchutney we should find something like endswith("_CM4") ?

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

@madchutney
I applied same kind of change as in ARMmbed/mbed-os#12630

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

@madchutney thx

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

ping

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

Please make a release version with this PR,
as it is needed with ARMmbed/mbed-os#13014

@jeromecoutant
Copy link
Copy Markdown
Contributor Author

ping

@rwalton-arm rwalton-arm merged commit e385192 into ARMmbed:master Jun 8, 2020
@rwalton-arm rwalton-arm mentioned this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants