Skip to content

Add dot to import in mbed/__main__.py to run as module#919

Merged
madchutney merged 1 commit intoARMmbed:masterfrom
JuhPuur:python3_run_as_module
Sep 10, 2019
Merged

Add dot to import in mbed/__main__.py to run as module#919
madchutney merged 1 commit intoARMmbed:masterfrom
JuhPuur:python3_run_as_module

Conversation

@JuhPuur
Copy link
Copy Markdown
Contributor

@JuhPuur JuhPuur commented Sep 5, 2019 •
edited
Loading

Running mbed as a module with python -m (to ensure it's running from virtualenv) with python3 causes the following:

Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/juhpuur/mbed-cli/mbed/__main__.py", line 1, in <module>
    from mbed import main
ImportError: cannot import name 'main'

The fix is to add a dot to the import in __main__.py to tell python to search current package before rest of PYTHONPATH.

madchutney
madchutney approved these changes Sep 5, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@madchutney madchutney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I prefer absolute imports but this looks ok.

@OPpuolitaival
Copy link
Copy Markdown
Contributor

OPpuolitaival commented Sep 6, 2019

@JuhPuur did run mbed-os ci flow and this seems to work fine

@madchutney madchutney merged commit 6f035de into ARMmbed:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madchutney madchutney madchutney approved these changes

+1 more reviewer

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JuhPuur @OPpuolitaival @madchutney