Includes app_config when starting get_config.py#907
Merged
mark-edgeworth merged 1 commit intoARMmbed:masterfrom Aug 20, 2019
Merged
Includes app_config when starting get_config.py#907mark-edgeworth merged 1 commit intoARMmbed:masterfrom
mark-edgeworth merged 1 commit intoARMmbed:masterfrom
Conversation
The get_config.py scripts supports providing the app_config file path as an argument, but mbed.py does not include it, when starting get_config.py, which means that the configuration being built will differ from the output of get_config.py, when building with an app_config != mbed_app.json.
mark-edgeworth
approved these changes
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_config.py scripts supports providing the app_config
file path as an argument, but mbed.py does not include it,
when starting get_config.py, which means that the configuration
being built will differ from the output of get_config.py, when
building with an app_config != mbed_app.json.