Skip to content

Fix mbed compile --flash#846

Merged
bridadan merged 1 commit intoARMmbed:masterfrom
vmedcy:fix-mbed-compile-flash
Feb 13, 2019
Merged

Fix mbed compile --flash#846
bridadan merged 1 commit intoARMmbed:masterfrom
vmedcy:fix-mbed-compile-flash

Conversation

@vmedcy
Copy link
Copy Markdown
Contributor

@vmedcy vmedcy commented Feb 13, 2019

Unknown error is thrown while executing mbed compile --flash:

[mbed] ERROR: Unknown Error: local variable 'baudrate' referenced before assignment

Add the required argument to compile_ method.
This also fixes another error while mbed compile --flash --baudrate 9600:

[mbed] ERROR: Unknown Error: compile_() got an unexpected keyword argument 'baudrate'

This is a regression introduced by #837

Unknown error is thrown while executing mbed compile --flash:

[mbed] ERROR: Unknown Error: local variable 'baudrate' referenced before assignment

Add the required argument to compile_ method.
This also fixes another error while mbed compile --flash --baudrate 9600:

[mbed] ERROR: Unknown Error: compile_() got an unexpected keyword argument 'baudrate'

This is a regression introduced by
#837
@vmedcy
Copy link
Copy Markdown
Contributor Author

vmedcy commented Feb 13, 2019

@theotherjimmy, @screamerbg: please consider this for 1.9.1: the regression in 1.9.0 was reported by various development teams in Cypress.

@screamerbg
Copy link
Copy Markdown
Contributor

Thanks for reporting this. I'll address it shortly.

Copy link
Copy Markdown
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the fix!

@screamerbg screamerbg self-requested a review February 13, 2019 16:26
@bridadan bridadan merged commit 7831cd1 into ARMmbed:master Feb 13, 2019
@screamerbg screamerbg mentioned this pull request Feb 13, 2019
@theotherjimmy
Copy link
Copy Markdown
Contributor

Thanks. 1.9.1 is out with this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants