Use bytes or %r to handle paths and process output#766
Closed
theotherjimmy wants to merge 3 commits intoARMmbed:masterfrom
Closed
Use bytes or %r to handle paths and process output#766theotherjimmy wants to merge 3 commits intoARMmbed:masterfrom
theotherjimmy wants to merge 3 commits intoARMmbed:masterfrom
Conversation
screamerbg
approved these changes
Oct 3, 2018
Contributor
screamerbg
left a comment
There was a problem hiding this comment.
Looks great! Thanks @theotherjimmy. You might want @toyowata to check this with his Japanese dev environment before merging.
Contributor
Author
|
I should get it working with python3 as well. |
Contributor
Author
|
This is very involved. Paths and other bytes being treated interchangeably with strings is everywhere in this code base. |
Contributor
Author
|
Closing in favor of #767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths are not ASCII, paths are not Unicode. Paths are bytes.
This PR handles paths like they are bytes, well at least the
current working directory. Handling paths and process output as
if they are unicode will introduce errors when paths are not
valid unicode. I tested this by creating a directory named
Which is not valid unicode, and tricks most python string
decoders into throwing an exception.
Fixes #710, maybe