Adding support for folder attribute in example project environment. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edriouk
reviewed
Dec 2, 2019
| * Gets the folder attribute stored in the environment tag. | ||
| * @return folder in the project, or null of it does not exist. | ||
| */ | ||
| String getProjectFolder(String environmentName); |
Contributor
There was a problem hiding this comment.
Interface change: requires default implementation
| * Return the folder attribute | ||
| * @return folder path, null if not supported. | ||
| */ | ||
| String getProjectFolder(); |
Contributor
There was a problem hiding this comment.
Interface change: requires default implementation
com.arm.cmsis.pack/src/com/arm/cmsis/pack/rte/examples/RteExampleItem.java
Show resolved
Hide resolved
| return getEnvironmentAttribute(environmentName, CmsisConstants.FOLDER); | ||
| } | ||
|
|
||
| private String getEnvironmentAttribute(String environmentName, String attributeName) { |
Contributor
There was a problem hiding this comment.
please change visibility to protected and add a comment. CpItem-based classes should be kept open for extension.
edriouk
approved these changes
Dec 2, 2019
Contributor
|
Thank you Joakim for the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file attribute in the project environment adds the metadata needed to supply compiler specific files in an example project.