Skip to content

Superflous CMake Calls to old ament  #403

@Ryanf55

Description

@Ryanf55

Per the ament docs, there is usage of superflous CMake functions that are old-style cmake (raw variables rather than target-based properties).

https://docs.ros.org/en/humble/How-To-Guides/Ament-CMake-Documentation.html

Branch: humble

It causes issues like this if you forget to pass the include variables up through each application.

~/Dev/geo_ws$ colcon build --packages-select grid_map_geo
Starting >>> grid_map_geo
--- stderr: grid_map_geo                             
<command-line>: fatal error: grid_map_core/eigen_plugins/FunctorsPlugin.hpp: No such file or directory
compilation terminated.
gmake[2]: *** [CMakeFiles/grid_map_geo.dir/build.make:76: CMakeFiles/grid_map_geo.dir/src/grid_map_geo.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/grid_map_geo.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< grid_map_geo [0.18s, exited with code 2]

I can issue a fix for grid_map_core.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ros2Affects ROS 2

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions