STYLE: CoordRepType -> CoordinateType code readability#1894
Merged
hjmjohnson merged 2 commits intomasterfrom Jun 19, 2025
Merged
STYLE: CoordRepType -> CoordinateType code readability#1894hjmjohnson merged 2 commits intomasterfrom
hjmjohnson merged 2 commits intomasterfrom
Conversation
be368b3 to
b54d5ff
Compare
Member
|
Thanks @hjmjohnson |
Collaborator
Author
|
NOTE: All 5.4 releases are forward compatible with the preferred naming. |
The two MersenneTwisterRandomVariateGenerator member functions and
behave the same, but is more commonly used, and clearer.
For the sake of code readability, a new 'CoordinateType' alias is added for each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be available with ITK 6.0, but it is recommended to use 'CoordinateType' instead. The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and 'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType', and 'ImagePointCoordRepType', respectively. Change implemented using: ```bash ITK/Utilities/Maintenance/migrate-itk6-code-recommendations.sh ```
b54d5ff to
ea66500
Compare
Collaborator
Author
|
One more missed change added. |
Collaborator
Author
|
This builds with both ITKv5.4 and ITKv6/master with LEGACY code removed. |
ntustison
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the sake of code readability, a new 'CoordinateType' alias is added for
each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be
available with ITK 6.0, but it is recommended to use 'CoordinateType' instead.
The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is
enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and
'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType',
and 'ImagePointCoordRepType', respectively.
Used ITK/Utilities/Maintenance/migrate-itk6-code-recommendations.sh to apply updates.