ENH: write template output such that things sort together#1771
Merged
ENH: write template output such that things sort together#1771
Conversation
Also improve error checking
Member
Author
|
Editing bash is always scary but I have run both the faces and the brain slices example successfully |
Contributor
|
If you're willing to go through some painful testing, this is the gold standard, And even more painful, getting to pass, https://github.com/koalaman/shellcheck |
Member
Author
|
Thanks @gdevenyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes
Replaced all the "let" statements and other traps that prevent running with
bash -e, and turned that on.Fixed error checking in pairwise registration stage
Attempted to make output more readable by prefixing input indices, rather than adding them at the end. Trying to make things easier to list and review, especially with multiple modalities