Skip to content

BUG: Manifold parzen windows.#1757

Merged
cookpa merged 1 commit intomasterfrom
ListSampleFunc
Jun 12, 2024
Merged

BUG: Manifold parzen windows.#1757
cookpa merged 1 commit intomasterfrom
ListSampleFunc

Conversation

@ntustison
Copy link
Member

Addresses #1664.

The different likelihood functions (e.g., Gaussian, ManifoldParzenWindows) are generated from a list of samples. For example, in the classic three tissue scenario, the voxels labeled as 'CSF' for the current iteration are fed into the first likelihood function which are used to estimate the likelihood function parameters (e.g., Gaussian mean). When I first wrote this, once these parameters were estimated, the samples were no longer needed so I wrote a function to clear the input sample list immediately after likelihood parameter estimation. However, this is no longer the case with the ManifoldParzenWindows, which relies on the Kdtree class which apparently needs to know the size of the input sample list during evaluation. This pull request removes the deletion of the input list sample after parameter estimation.

@cookpa
Copy link
Member

cookpa commented Jun 12, 2024

Thanks @ntustison !

@cookpa cookpa merged commit 29e8580 into master Jun 12, 2024
@cookpa cookpa deleted the ListSampleFunc branch June 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants