Skip to content

ENH: Add Ubuntu 24.04#1751

Merged
cookpa merged 1 commit intoANTsX:masterfrom
gdevenyi:patch-1
May 21, 2024
Merged

ENH: Add Ubuntu 24.04#1751
cookpa merged 1 commit intoANTsX:masterfrom
gdevenyi:patch-1

Conversation

@gdevenyi
Copy link
Contributor

Add 24.04 by copy-paste of the existing GH action.

@cookpa
Copy link
Member

cookpa commented May 21, 2024

Thanks, happy to add this, have you verified that it builds?

@gdevenyi
Copy link
Contributor Author

I was expecting it to build here in the PR, but I guess it won't since its a release-only trigger. I'm trying to figure out how to do it manually on my fork now...

@cookpa
Copy link
Member

cookpa commented May 21, 2024

It is annoying and I probably should make a workflow_dispatch option. The way I currently test is to make releases on my fork.

@cookpa
Copy link
Member

cookpa commented May 21, 2024

You know, I will just test it, I have it all set up

@gdevenyi
Copy link
Contributor Author

The way I currently test is to make releases on my fork.

I figured, I just tried that on my fork and it didn't work for me :-/

@cookpa
Copy link
Member

cookpa commented May 21, 2024

Yeah, you have to enable actions, and then disable the ones you don't want...I will fix this because things break on release and it would be good to be able to test

@cookpa
Copy link
Member

cookpa commented May 21, 2024

Looks like Actions is busy today, but will update when it runs

@gdevenyi
Copy link
Contributor Author

How fast are the builds? I was looking at adding this
https://github.com/marketplace/actions/ccache-for-gh-actions

But like this I can't really test it easily...

@cookpa
Copy link
Member

cookpa commented May 21, 2024

About an hour. I've used the cache before in python, it can help but caches only last a week so they are good for a nightly build but not really for releases

@cookpa cookpa merged commit 49cad23 into ANTsX:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants