ENH: Support averaging affine transforms with float parameters#1682
ENH: Support averaging affine transforms with float parameters#1682cookpa merged 1 commit intoANTsX:masterfrom
Conversation
So far, this was only possible with double parameters.
b094be2 to
acd1d62
Compare
|
Review/merge? This builds locally, and does not introduce any new test failures. |
|
Looks good to me, have you confirmed that AverageAffineTransform / AverageAffineTransformNoRigid work as before? These are critical to the template building scripts, and I don't know if they are covered by the automated tests. |
|
I'm building now and will test today |
|
The changes changes only add a new way to use the class, they do not change how class behaves. Trying to use it with float affine matrices caused compile error. The new code path is untested for now. But it should be tested soon by unit tests in https://github.com/dzenanz/ANTsWasm. Of course, adding some tests for the float affine averaging within this repository would be good, but I have no plans to do that. Anyone is welcome to do so. |
|
Thanks, merging |
So far, this was only possible with double parameters.