Skip to content

COMP: Fix compile warning C4858: discarding return value in std::remove#1660

Merged
cookpa merged 2 commits intoANTsX:masterfrom
dzenanz:compFix
Jan 18, 2024
Merged

COMP: Fix compile warning C4858: discarding return value in std::remove#1660
cookpa merged 2 commits intoANTsX:masterfrom
dzenanz:compFix

Conversation

@dzenanz
Copy link
Contributor

@dzenanz dzenanz commented Jan 18, 2024

Closes #1652.

C:\Dev\ANTs\Examples\sccan.cxx(2593,8): warning C4858: discarding return value: The 'remove' and 'remove_if' algorithms return the iterator past the last element that should be kept. You need to call container.erase(result, container.end()) afterwards. In C++20, 'std::erase' and 'std::erase_if' are simpler replacements for these two steps.
@cookpa cookpa merged commit dcdc878 into ANTsX:master Jan 18, 2024
@dzenanz dzenanz deleted the compFix branch January 18, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings possibly indicating problems

2 participants