Fix wrong number of initial parameter num for commented syscall_socket#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the initial KENS project, initial parameter for syscall_socket was
syscallUUID, pid, param.param1_int, param.param2_int. (commented out at systemCallback)But, after reading the documentation and doing the project, I found out that syscall_socket needs "3" parameters other than syscallUUID and pid: domain, type, and protocol. So, the initial parameter should be
syscallUUID, pid, param.param1_int, param.param2_int, param.param3_int.At first this caused me confusion, because the official KENS source code was written as 2 parameters.
Other commented out initial parameters (such as syscall_bind, syscall_close ..) was okay. I think that changing the typo with the right number of parameters should be necessary to avoid confusion.
Sorry for the late change request, but I thought that it is better late than never.