delete post functionality on each post#26
Merged
Pranav016 merged 1 commit intoALPHAVIO:masterfrom Jan 21, 2021
Merged
Conversation
Pranav016
approved these changes
Jan 21, 2021
Member
|
I checked the code, seems good. Can you share a screen recording of the working of the feature you added, put it in the comments itself. Since the website isn't deployed yet and I don't have Mongo on my Gitpod so I can't test the feature. |
Author
|
Sure
…On Thu, 21 Jan, 2021, 4:58 PM Pranav, ***@***.***> wrote:
I checked the code, seems good. Can you share a screen recording of the
working of the feature you added, put it in the comments itself. Since the
website isn't deployed yet and I don't have Mongo on my Gitpod so I can't
test the feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOA72GG2OQ3IL5DLVKWIYSTS3AFWTANCNFSM4WMIKHUQ>
.
|
Author
blog_post_delete.mp4 |
Member
Excellent work @mak-ux . I am merging this time but just keep in mind next time that work on a new branch before making a PR. Never commit to master and write good commit messages. These are the best practices. Happy Learning! |
Member
|
@all-contributors please add @mak-ux for code |
|
I've put up a pull request to add @mak-ux! 🎉 |
Member
|
@all-contributors please add @mak-ux for code |
|
I've put up a pull request to add @mak-ux! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #22