Skip to content

style-added animation to the navbar links#153

Merged
Pranav016 merged 1 commit intoALPHAVIO:developfrom
mcmonojit:navbar-animation-mcmonojit
Feb 11, 2021
Merged

style-added animation to the navbar links#153
Pranav016 merged 1 commit intoALPHAVIO:developfrom
mcmonojit:navbar-animation-mcmonojit

Conversation

@mcmonojit
Copy link
Copy Markdown

What is the change?

Added animation to the navbar links and removed the outline of dark mode button.

Related issue?

issue: #110

How was it tested?

Manual testing.

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • Have you followed the Contribution Guidelines while contributing.
  • Have you checked there aren't other open Pull Requests for the same update/change?
  • Have you made corresponding changes to the documentation?
  • Your submission doesn't break any existing feature.
  • Have you tested the code before submission?

Screenshots or Video:

1

Copy link
Copy Markdown
Member

@Pranav016 Pranav016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, small mistakes from last PR were taken care of this time 👍

@Pranav016 Pranav016 merged commit 5126d64 into ALPHAVIO:develop Feb 11, 2021
@mcmonojit
Copy link
Copy Markdown
Author

Yes, actually I am learning the git workflows so in the first PR I made quite a number of mistakes. I feel the following areas of the project can be worked on

  • making the site mobile responsive ( navbar with hamburger menu and corresponding modification to the components of the body )
  • adding support for bold text, line breaks, links and images in the blog post.

@Pranav016
Copy link
Copy Markdown
Member

Yes, actually I am learning the git workflows so in the first PR I made quite a number of mistakes. I feel the following areas of the project can be worked on

  • making the site mobile responsive ( navbar with hamburger menu and corresponding modification to the components of the body )
  • adding support for bold text, line breaks, links and images in the blog post.

Sure, I'll keep these features in mind as we develop this website. If you feel if there is any feature/ issue needs to be solved that you can work on, just raise the issue and can start working. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants