Skip to content

Aligned dark mode button to bottom left corner#145

Merged
Pranav016 merged 1 commit intoALPHAVIO:developfrom
Abhijay007:develop
Feb 8, 2021
Merged

Aligned dark mode button to bottom left corner#145
Pranav016 merged 1 commit intoALPHAVIO:developfrom
Abhijay007:develop

Conversation

@Abhijay007
Copy link
Copy Markdown

@Abhijay007 Abhijay007 commented Feb 8, 2021

What is the change?

I improved the alignment of the dark mode button and removed unnecessary code from the codebase

Now What is mean by unnecessary code?
The dark mode.js is defined two times in the codebase both in app.js and footer.ejs which causes an alignment issue but I fixed that

before
before

after
after

Related issue?

issue: #114 Align dark mode button to bottom left corner

How was it tested?

I tested the code by running it on my localhost and also test its responsiveness and other parameters using the chrome inspect element.

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • Have you followed the Contribution Guidelines while contributing.
  • Have you checked there aren't other open Pull Requests for the same update/change?
  • Your submission doesn't break any existing feature.
  • Have you tested the code before submission?

@Pranav016 Pranav016 merged commit a88fb66 into ALPHAVIO:develop Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants