Skip to content

Add CKEditor#206

Merged
Pranav016 merged 5 commits intoALPHAVIO:developfrom
luckykumarirai:add-ckeditor
Feb 23, 2021
Merged

Add CKEditor#206
Pranav016 merged 5 commits intoALPHAVIO:developfrom
luckykumarirai:add-ckeditor

Conversation

@luckykumarirai
Copy link
Copy Markdown

@luckykumarirai luckykumarirai commented Feb 22, 2021

What is the change?

Add CKEditor instead of textarea that provide flexibility to change the font style of content, add images and tables.

Related issue?

issue: #205

How was it tested?

I have tested it in my local system.

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • Have you followed the Contribution Guidelines while contributing.
  • Have you checked there aren't other open Pull Requests for the same update/change?
  • Have you made corresponding changes to the documentation?
  • Your submission doesn't break any existing feature.
  • Have you tested the code before submission?

Screenshots or Video:

Screenshot from 2021-02-22 20-24-17

Pranav016
Pranav016 requested changes Feb 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pranav016 Pranav016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New PRs got merged so some merge conflicts have risen. I'll test the code after they are resolved. 👍

@luckykumarirai luckykumarirai changed the title Add ckeditor Solve conflicts Feb 22, 2021
@luckykumarirai
Copy link
Copy Markdown
Author

luckykumarirai commented Feb 22, 2021

New PRs got merged so some merge conflicts have risen. I'll test the code after they are resolved.

@Pranav016 I have resolved the conflicts now you can test.

@luckykumarirai luckykumarirai changed the title Solve conflicts Add CKEditor Feb 23, 2021
Pranav016
Pranav016 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Pranav016 Pranav016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now I am merging the PR based on the demo in #165

@Pranav016 Pranav016 merged commit 160baab into ALPHAVIO:develop Feb 23, 2021
@Pranav016 Pranav016 mentioned this pull request Feb 23, 2021
Closed
@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 23, 2021

@all-contributors please add @luckykumarirai for code

@allcontributors allcontributors bot mentioned this pull request Feb 23, 2021
Merged
@allcontributors
Copy link
Copy Markdown

allcontributors bot commented Feb 23, 2021

@Pranav016

I've put up a pull request to add @luckykumarirai! 🎉

@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 24, 2021 •
edited
Loading

@luckykumarirai the build for the website is failing after this PR. I noticed that there are changes made to the package-lock.json file in this PR ?

@luckykumarirai
Copy link
Copy Markdown
Author

luckykumarirai commented Feb 24, 2021 •
edited
Loading

@Pranav016 what do I have to do for solving this problem?
Because I have not made changes in any other files except 2 or 3 files.

@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 24, 2021 •
edited
Loading

@Pranav016 what do I have to do for solving this problem?
Because I have not made changes in any other files except 2 or 3 files.

Right now I took care of it 👍 Temporary fix though, took a couple of hours.
Will let you know if any other help is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pranav016 Pranav016 Pranav016 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luckykumarirai @Pranav016