Skip to content

Added favicon successfully#117

Merged
Pranav016 merged 1 commit intoALPHAVIO:developfrom
HarshitAditya27:addedfavicon
Feb 4, 2021
Merged

Added favicon successfully#117
Pranav016 merged 1 commit intoALPHAVIO:developfrom
HarshitAditya27:addedfavicon

Conversation

@HarshitAditya27
Copy link
Copy Markdown

@HarshitAditya27 HarshitAditya27 commented Feb 4, 2021

What is the change?

I have added a favicon for the website, code written in header.ejs (code:).The favicon is located in the images folder which is inside the public folder and I have set the value of const URL which is const URL = process.env.URL; (as instructed by you) and one more thing the favicon created is simple it's just the logo with the border of color combination white and pink and I have removed extra lines. I hope you will like my favicon :). (This PR is the updated version of issue no #115 )

Related issue?

issue: #105

How was it tested?

I have tested the website by using the hyper terminal and mongod server.

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • Have you followed the Contribution Guidelines while contributing.
  • Have you checked there aren't other open Pull Requests for the same update/change?
  • Have you made corresponding changes to the documentation?
  • Your submission doesn't break any existing feature.
  • Have you tested the code before submission?

Screenshots or Video:

Add a screenshot or demo video if appropriate.
Screenshot (576)_LI

@HarshitAditya27 HarshitAditya27 mentioned this pull request Feb 4, 2021
Closed
5 tasks
@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 4, 2021 •
edited
Loading

Why is the commit message Added favicon "successfully". No need for successfully, and commit messages should be in present tense. Also you did not close your previous PR before making this new PR. Please keep that in mind.

Run these commands to correct the commit message and then I'll merge your PR

git commit --amend -m "Add Favicon"
git push origin addedfavicon -f

@Pranav016 Pranav016 requested review from Pranav016 and removed request for Pranav016 February 4, 2021 10:33
@HarshitAditya27
Copy link
Copy Markdown
Author

HarshitAditya27 commented Feb 4, 2021 •
edited
Loading

Sir, I have changed the commit message "Added favicon successfully" to "Add Favicon" as you said :). Sir, actually I thought that closing the previous PR would affect my current PR that's why I have not closed the previous one, I am very sorry for that, from now onwards this would not happen again :) .

@Pranav016 Pranav016 merged commit 4c5beb0 into ALPHAVIO:develop Feb 4, 2021
@HarshitAditya27
Copy link
Copy Markdown
Author

HarshitAditya27 commented Feb 4, 2021

Thanks a lot, sir !!!. Finally, I did my first contribution !!! and thank you for guiding and mentoring me :) :) :) .

@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 4, 2021

@all-contributors please add @HarshitAditya27 for code

@allcontributors allcontributors bot mentioned this pull request Feb 4, 2021
Merged
@allcontributors
Copy link
Copy Markdown

allcontributors bot commented Feb 4, 2021

@Pranav016

I've put up a pull request to add @HarshitAditya27! 🎉

@Pranav016
Copy link
Copy Markdown
Member

Pranav016 commented Feb 4, 2021

Thanks a lot, sir !!!. Finally, I did my first contribution !!! and thank you for guiding and mentoring me :) :) :) .

My pleasure. I hope you were able to learn a lot of things.

@HarshitAditya27
Copy link
Copy Markdown
Author

HarshitAditya27 commented Feb 4, 2021

Yes Sir I learned a lot of things under your guidance (thanks a lot for your guidance ) !!! looking forward to more contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarshitAditya27 @Pranav016